Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Add forced resolve to command and prittify and detail output #967

Merged

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented Jul 27, 2017

Q A
Branch? 1.0
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #966
License MIT
Doc PR

The PR changes the following aspects of the liip:imagine:cache:resolve command:

  • Adds a --force option that forces re-resolution an image, regardless of cache.
  • Expands the output to provide more detailed information on the actions executed.
  • Allows resolution failures and continues with the other passed images and filters.
  • Amends the --help output to make it easier to follow and clearer at a glance.
  • A --machine option has been added that removed the title and summary from the output and only outputs machine-parsable lines.
  • Deprecates the --filters option in favor of a --filter option (you only pass one filter per call to it, so it should not be plural).

Here is the new --help output:

liip-imagine-bundle-resolve-command-help

Here is the output with errors:

liip-imagine-bundle-cache-resolve-errors

Here is the new default behavior output (showing the image name, filter name, and resolved path):

liip-imagine-bundle-cache-resolve-cached-output

Here is the output when forcing resolution, ignoring the cache:

liip-imagine-cache-resolve-resolved-output

Here is the output with --machine enabled:

liip-imagine-bundle-cache-resolve-machine

And finally, here is the output showing cached, resolved, and failed items from one invocation:

liip-imagine-bundle-cache-resolve-complete

@robfrawley robfrawley added the Level: New Feature 🆕 This item involves the introduction of new functionality. label Jul 27, 2017
@robfrawley robfrawley added this to the 1.9.0 milestone Jul 27, 2017
@robfrawley robfrawley self-assigned this Jul 27, 2017
@robfrawley robfrawley mentioned this pull request Jul 27, 2017
@robfrawley robfrawley requested a review from alexwilson July 27, 2017 12:14
@robfrawley robfrawley force-pushed the feature-add-force-resolve-command-and-prettify branch 3 times, most recently from 4141cc4 to b97a503 Compare July 28, 2017 17:09
@robfrawley
Copy link
Collaborator Author

@cedricziel @antoligy I want to get a release tagged shortly; any objections to this PR? Time to review?

Copy link
Collaborator

@alexwilson alexwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not gone over the tests in complete detail (assuming that more is better and that they're not too brittle), the formatting changes seem sane.

I'm loving the improved docs!

@robfrawley robfrawley changed the title [WIP] [Console] Add forced resolve to command and prittify and detail output [Console] Add forced resolve to command and prittify and detail output Aug 30, 2017
@robfrawley robfrawley force-pushed the feature-add-force-resolve-command-and-prettify branch 2 times, most recently from 0310e0a to 1c9811e Compare August 31, 2017 00:10
@robfrawley robfrawley merged commit 67b058c into liip:1.0 Aug 31, 2017
@robfrawley robfrawley mentioned this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants